[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 22 17:24:09 PST 2020


MaskRay added a comment.

`ARMAttributeParser` has lots of boilerplate code and many untested parsing errors. I think we should improve the existing interface so that the newly added RISCVAttributeParser will not add another sets of untested code paths.

`ARMAttributeParser` can be simplified a lot by leverating `DataExtractor`. So I created D75015 <https://reviews.llvm.org/D75015>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023





More information about the llvm-commits mailing list