[PATCH] D75015: [ARM] Rewrite ARMAttributeParser

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: compnerd, grimar, HsiangKai, jhenderson.
Herald added subscribers: llvm-commits, rupprecht, hiraditya, kristof.beyls, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

- Delete boilerplate
- Change functions to return `Error`
- Test parsing errors
- Update callers of ARMAttributeParser::parse() to check the `Error` return value.

Since this patch touches nearly everything in the file, I apply
http://llvm.org/docs/Proposals/VariableNames.html and change variable
names to lower case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75015

Files:
  lld/ELF/InputFiles.cpp
  lld/test/ELF/arm-tag-vfp-args-illegal.s
  lld/test/ELF/invalid/bad-arm-attributes.s
  lld/test/ELF/invalid/bad-arm-attributes2.s
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/include/llvm/Support/ARMAttributeParser.h
  llvm/include/llvm/Support/DataExtractor.h
  llvm/lib/Support/ARMAttributeParser.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/unittests/Support/ARMAttributeParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75015.246091.patch
Type: text/x-patch
Size: 61818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200223/232683a4/attachment.bin>