[PATCH] D74691: [Attributor] add some pattern to containsCycle

[omar ahmed via Phabricator via llvm-commits]

omarahmed marked an inline comment as done.
omarahmed added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2383
+  for (scc_iterator<Function *> I = scc_begin(&F), IE = scc_end(&F); I != IE;
+       ++I) {
+    const std::vector<BasicBlock *> &SCCBBs = *I;
----------------
jdoerfert wrote:
> Nit: Maybe `for (auto &It : make_range(scc_begin(&F), scc_end(&F)))`
> Or create a helper `scc_range(..)` that create the range.
I am kind of stuck in using hasLoop function with using these method for looping :) , so how could I change It( vector<Block*>) to SCC_iter<Function *> type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691