[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.
    Johannes Doerfert via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat Feb 22 08:17:14 PST 2020
    
    
  
jdoerfert added reviewers: ggeorgakoudis, lebedev.ri.
jdoerfert added a comment.
Thx! I'll ask more people to look at the barrier/flush stuff to make sure my suggestion wrt. inacc+argmemonly was correct.
The ones I would also love to see are the worksharing loop functions (end with _init_4, _fini etc.). Maybe we should do those and the getters/setters separate to speed things up.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:277
+                AttributeSet(EnumAttr(InaccessibleMemOrArgMemOnly)),
+                AttributeSet(), {})
+__OMP_RTL_ATTRS(__kmpc_cancel,
----------------
I will have to think about the barrier and flush ones.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:278
 
-__OMP_RTL_ATTRS(__kmpc_global_thread_num, GetterAttrs, AttributeSet(), {})
 __OMP_RTL_ATTRS(omp_get_thread_num, GetterAttrs, AttributeSet(), {})
----------------
Where did this one go?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75010/new/
https://reviews.llvm.org/D75010
    
    
More information about the llvm-commits
mailing list