[PATCH] D74176: [CMake] Link against ZLIB::ZLIB

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM.

If this is picked to 10.0, D74106 <https://reviews.llvm.org/D74106> will need to be picked as well, right?



================
Comment at: llvm/lib/Support/CMakeLists.txt:198
+  if(NOT zlib_library)
+    get_property(zlib_library TARGET ZLIB::ZLIB PROPERTY LOCATION)
+  endif()
----------------
I tested locally with CMake 3.4.3, and it looks like `LOCATION` works for reading even on that version, so I'm just gonna assume it also works in subsequent versions :D


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74176/new/

https://reviews.llvm.org/D74176