[PATCH] D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3018
+      for (int i = 0; i < Repetitions; ++i)
+        ValuesAsInt.append(DuplicatedValues.begin(), DuplicatedValues.end());
+    } else {
----------------
epastor wrote:
> thakis wrote:
> > Is there no more efficient way to express this internally? If you `1000000 dup (2)`, do we have to write out 1M 2s?
> We could optimize the case of `1000000 dup (2)` with a fill-type instruction, but I'm not sure how we would handle (e.g.) `500000 dup (2,3)`. Also, this is data-initialization logic, so either way the actual binary is going to contain 1M literal copies. Do you think it's worth special-casing the single-value handling internally anyway?
as-is is fine for now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73226/new/

https://reviews.llvm.org/D73226