[PATCH] D74691: [Attributor] add some pattern to containsCycle

Fri Feb 21 17:24:33 PST 2020

jdoerfert added a comment.

In D74691#1887414 <https://reviews.llvm.org/D74691#1887414>, @baziotis wrote:

> In D74691#1887241 <https://reviews.llvm.org/D74691#1887241>, @omarahmed wrote:
>
> > @jdoerfert I have found examples in the willreturn.ll file for explicit tests for bounded and unbounded loops  and I fixed them , does we need to add more complex examples like a bounded loop inside unbounded loop or this is redundant and not important ?
>
>
> I think you can first of all upload your diff and it will be easier to comment on what is missing. Some tests you can add (or check if there are some already in `willreturn.ll`) are basically stressing the algorithm.
>  That e.g. means add a quite deep loop. Add a non-loop SCC inside a loop. Add a loop that has max trip count inside another with max trip count (so you can check the moving upwards).

Yes. Please keep the diff up to date so it is easier to follow.

[ Btw. if someone is up for it I have already the next extension in mind. though we can tackle that once this one is done ]

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691