[PATCH] D74989: [LoopTerminology] Loop Simplify Form

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/docs/LoopTerminology.rst:147-149
+The Loop Simplify Form is a canonical form that makes
+several analyses and transformations simpler and more effective.
+For a loop to be in Loop Simplify Form, it must have:
----------------
Could you add that the LoopSimplify (`-loop-simplify`) pass ensures this form and is automatically added by the pass managers when scheduling a LoopPass?


================
Comment at: llvm/docs/LoopTerminology.rst:152
+* A preheader.
+* A latch which must also be the only backedge.
+* Dedicated exists. That is, no exit block for the loop
----------------
[serious] There can be a single latch with multiple edges to the header (e.g. a switch)


================
Comment at: llvm/docs/LoopTerminology.rst:153
+* A latch which must also be the only backedge.
+* Dedicated exists. That is, no exit block for the loop
+  has a predecessor that is outside the loop. This implies
----------------
[typo] exits


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74989/new/

https://reviews.llvm.org/D74989