[PATCH] D73130: [MLIR] Add support for libMLIR.so

[Valentin Churavy via Phabricator via llvm-commits]

vchuravy added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:40-41
+  else()
+    # llvm_add_library ignores BUILD_SHARED_LIBS if STATIC is explicitly set,
+    # so we need to handle it here.
+    if(BUILD_SHARED_LIBS)
----------------
stephenneuendorffer wrote:
> comment is obsolete?
I copied this from the clang shlib, so if this is indeed obsolete
we should remove it there as well.


================
Comment at: mlir/tools/mlir-shlib/CMakeLists.txt:6
+
+# Building libmlir-cpp.so may not work on MSVC
+if (MSVC)
----------------
This is copied as well from the clang shlib and https://reviews.llvm.org/D73156 so it would be great if we can fix that generally,
but I don't have easy access to a MSVC environment. I build my windows binaries with mingw.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73130/new/

https://reviews.llvm.org/D73130