[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:23
 	StringRef Name;
-	uint8_t   Type;
+        int16_t TypeOrSmc; ///< For Elf, it stores the symbol type.
+                           ///< for XCOFF, it store storage mapping class of
----------------
In English text, this should be "ELF" in all caps.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:149
+    SymbolDescription("symbol-description",
+                      cl::desc("Add symbol description for dissembly"),
+                      cl::init(false), cl::cat(ObjdumpCat));
----------------
s/dissembly/disassembly/;


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:152
+static cl::alias SymbolDescriptionShort(
+    "E", cl::desc("Alias for --Add Symbol Description for dissembly"),
+    cl::NotHidden, cl::Grouping, cl::aliasopt(SymbolDescription));
----------------
I would not recommend adding a short option without coordinating the short option with the GNU binutils beforehand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973