[PATCH] D74808: [MachO][NFC] Extract all CPU_(SUB_)TYPE logic to libObject

Fri Feb 21 13:16:14 PST 2020

fpetrogalli added a comment.

Hi @thegameg, this commit is breaking the shared libs builds. Could you please make sure you code works when configuring with `-DBUILD_SHARED_LIBS=On`?

Thank you!

  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  [14/93] Linking CXX shared library lib/libLLVMAnalysis.so.11git
  ninja: build stopped: subcommand failed.
  1874dee5662603c9251228c71b66de72cec0c979 is the first bad commit
  commit 1874dee5662603c9251228c71b66de72cec0c979
  Author: Francis Visoiu Mistrih <francisvm at yahoo.com>
  Date:   Tue Feb 18 16:39:05 2020 -0800

      [macho][NFC] Extract all CPU_(SUB_)TYPE logic to BinaryFormat

      This moves all the logic of converting LLVM Triples to
      MachO::CPU_(SUB_)TYPE from the specific target (Target)AsmBackend to
      more convenient functions in lib/BinaryFormat.

      This also gets rid of the separate two X86AsmBackend classes.

      The previous attempt was to add it to libObject, but that adds an
      unnecessary dependency to libObject from all the targets.

      Differential Revision: https://reviews.llvm.org/D74808

  :040000 040000 a02bd9834ed78adda514673d37fede6d5f0308a7 81560f612058cf731629ee17d8e638f99051da21 M	llvm
  bisect run success

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74808/new/

https://reviews.llvm.org/D74808