[PATCH] D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.

[Eric Astor via Phabricator via llvm-commits]

epastor marked 2 inline comments as done.
epastor added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:2889
+
+    // Continue if we see a comma. (Also, allow line continuation.)
+  } while (parseOptionalToken(AsmToken::Comma) &&
----------------
thakis wrote:
> What does ml do with
> 
> ```
> BYTE 2, 4, 6, 8,
> BYTE 2, 4, 6, 8,
> ```
> 
> ? Does it really error out?
Believe it or not, yes! 
```
test.asm(2) : error A2206:missing operator in expression
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73226/new/

https://reviews.llvm.org/D73226