[PATCH] D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:134
+public:
+  AttrDictDirective(bool withKeyword) : withKeyword(withKeyword) {}
+  bool isWithKeyword() const { return withKeyword; }
----------------
Nit: explicit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74682/new/

https://reviews.llvm.org/D74682