[PATCH] D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:152
+    /// Number of operands controlling the loop: lb, ub, step
+    constexpr unsigned getNumControlOperands() { return 3; }
+    /// Does the operation hold operands for loop-carried values
----------------
rriddle wrote:
> This doesn't build with GCC 5, remove the constexpr.
See: https://buildkite.com/mlir/mlir-core/builds/2902#6c915245-aa53-4a8f-87af-0258275b27af

Could you please take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74174/new/

https://reviews.llvm.org/D74174