[PATCH] D74506: [SystemZ] Support the kernel backchain
Jonas Paulsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 21 09:09:37 PST 2020
jonpa added inline comments.
================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:1478
+ unsigned Offset = TFL->getRegSpillOffset(MF, SystemZ::ArgFPRs[I]);
int FI = MFI.CreateFixedObject(8, RegSaveOffset + Offset, true);
SDValue FIN = DAG.getFrameIndex(FI, getPointerTy(DAG.getDataLayout()));
----------------
uweigand wrote:
> I believe this now needs to be -SystemZMC::CallFrameSize + Offset instead of RegSaveOffset + Offset.
I think that should be equivalent due to the '!(IsVarArg && !SoftFloat)' check in getRegSpillOffset().
Would it be clearer to use -SystemZMC::CallFrameSize here still?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74506/new/
https://reviews.llvm.org/D74506
More information about the llvm-commits
mailing list