[PATCH] D74461: Remove static registration for dialects, and the "alwayslink" hack for passes

Fri Feb 21 09:09:37 PST 2020

mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.

================
Comment at: mlir/lib/Dialect/CMakeLists.txt:36-52
+target_link_libraries(MLIRAllDialects
+  MLIRAffineOps
+  MLIRFxpMathOps
+  MLIRGPU
+  MLIRLLVMIR
+  MLIRNVVMIR
+  MLIRROCDLIR
----------------
stephenneuendorffer wrote:
> Do you actually want this library to exist, or just to have an easy way to structure CMakeFiles?
> This doesn't help the latter for BUILD_SHARED_LIBS=on because you still need to specify all libraries you have a dependence against.
> My preference would be to have add_mlir_dialect generate a list of dialects which can be used to solve the second problem.
Do you mean add_mlir_dialect would build a CMake macro like "ALL_MLIR_DIALECTS" and this macro would be used to link them all in place where we use MLIRAllDialects right now? That works for me!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74461/new/

https://reviews.llvm.org/D74461