[PATCH] D74945: AMDGPU/GlobalISel: Fix xnor matching
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 21 08:42:02 PST 2020
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-and.mir:152
; WAVE64: [[COPY1:%[0-9]+]]:sreg_32 = COPY $sgpr1
- ; WAVE64: [[S_AND_B32_:%[0-9]+]]:sreg_32 = S_AND_B32 [[COPY]], [[COPY1]], implicit-def dead $scc
+ ; WAVE64: [[S_AND_B32_:%[0-9]+]]:sreg_32 = S_AND_B32 [[COPY]], [[COPY1]], implicit-def $scc
; WAVE64: S_ENDPGM 0, implicit [[S_AND_B32_]]
----------------
foad wrote:
> Any particular reason we lose the "dead" here? Does it matter?
We were manually setting that flag in the manual matcher, but it doesn't matter. It can be inferred later
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74945/new/
https://reviews.llvm.org/D74945
More information about the llvm-commits
mailing list