[PATCH] D74349: [PowerPC][AIX] Spill and restore the non-volatile condition register bits.

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 08:32:38 PST 2020


Xiangling_L accepted this revision.
Xiangling_L added a comment.
This revision is now accepted and ready to land.

LGTM with a minor comment



================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:929
+      MachineInstrBuilder MIB =
+          BuildMI(MBB, MBBI, dl, TII.get(PPC::MFOCRF8), TempReg);
+      MIB.addReg(MustSaveCRs[0], RegState::Kill);
----------------
minor issue: inconsistency between how to get instruction `TII.get(PPC::MFOCRF8)`  and `MoveFromCondRegInst`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74349/new/

https://reviews.llvm.org/D74349





More information about the llvm-commits mailing list