[PATCH] D74712: Remove *_finite libary support, following upstream
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 21 07:09:53 PST 2020
serge-sans-paille updated this revision to Diff 245845.
serge-sans-paille added a comment.
As hinted by @efriedma , only remove lowering to `*_finite calls` in Codegen.
I contacted the libm maintainer and here is his explanation:
> They were only ever an ABI (selected by use of -ffinite-math-only or
> options implying it, which resulted in the headers using "asm" to redirect
> calls to some libm functions), not an API. The change means that ABI has
> turned into compat symbols (only available for existing binaries, not for
> anything newly linked, not included in static libm at all, not included in
> shared libm for future glibc ports such as RV32), so, yes, in any case
> where tools generate direct calls to those functions (rather than just
> following the "asm" annotations on function declarations in the headers),
> they need to stop doing so.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74712/new/
https://reviews.llvm.org/D74712
Files:
llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74712.245845.patch
Type: text/x-patch
Size: 5127 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200221/f183a69c/attachment.bin>
More information about the llvm-commits
mailing list