[PATCH] D74863: AMDGPU/GlobalISel: Fix SALU mapping for v2s16 min/max

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 07:00:32 PST 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks OK to me.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1563
+                                               Register Src1) {
+  const LLT CmpType = LLT::scalar(32);
+  auto Cmp = B.buildICmp(Pred, CmpType, Src0, Src1);
----------------
Just curious: why s32 instead of s1 for comparison results?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74863/new/

https://reviews.llvm.org/D74863





More information about the llvm-commits mailing list