[PATCH] D71354: CodeGen: Add -denormal-fp-math-f32 flag

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.inc:442-443
 
+  if (DenormalFPMath.getNumOccurrences() > 0 &&
+      !F.hasFnAttribute("denormal-fp-math")) {
+    // FIXME: Command line flag should expose separate input/output modes.
----------------
If I'm seeing this and the test correctly, the function attribute overrides any command-line debug flag. That could use a comment; if that's consistent across all of the attributes handled here, make that a function-level comment?


================
Comment at: llvm/test/Other/opt-override-denormal-fp-math.ll:23
+attributes #0 = { nounwind }
+attributes #1 = { nounwind "denormal-fp-math"="preserve-sign,ieee" }
----------------
Add a test or separate file where the function contains both of the denorm attrs simultaneously?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71354/new/

https://reviews.llvm.org/D71354