[PATCH] D74889: [mlir] Generalize intrinsic builders in the LLVM dialect definition

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 05:47:45 PST 2020


ftynse added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td:59
 
-// Base class for LLVM intrinsics operation. It is the same as an LLVM_Op
-// but the operation has a ".intr." element in the prefix becoming
-// "llvm.intr.*".
+// Deprecated compatibility class for LLVM intrinsic operations.
 class LLVM_IntrOp<string mnemonic, list<OpTrait> traits = []> :
----------------
aartbik wrote:
> If this is deprecated, add a TODO on the plan on the path forward (e.g. remove when ....)
After all, I'll update this and all users in the next commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74889/new/

https://reviews.llvm.org/D74889





More information about the llvm-commits mailing list