[PATCH] D74762: AMDGPU/GlobalISel: Select llvm.amdgcn.fdot2

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 04:08:44 PST 2020


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM

> I'm slighly worried about the generated checks, since they won't catch incorrect modifiers being added at the end of the line.

Maybe the script could be changed to add {{$}} everywhere? Though that would end up looking really ugly :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74762/new/

https://reviews.llvm.org/D74762





More information about the llvm-commits mailing list