[PATCH] D74927: [MC][ARM] make Thumb function also if type attribute is set

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:590
 
+  bool EmitSymbolAttribute(MCSymbol *S, MCSymbolAttr Attribute) {
+    bool val = MCELFStreamer::EmitSymbolAttribute(S, Attribute);
----------------
If it's overriding a virtual method, please mark it `override`.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:597
+    auto *Symbol = cast<MCSymbolELF>(S);
+    unsigned Type = cast<MCSymbolELF>(Symbol)->getType();
+    if (Type == ELF::STT_FUNC || Type == ELF::STT_GNU_IFUNC)
----------------
This `cast<MCSymbolElf` looks redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74927/new/

https://reviews.llvm.org/D74927