[PATCH] D74880: [mlir] [VectorOps] Multi-dim reductions for lowering vector.contract
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 20 14:23:28 PST 2020
rriddle added inline comments.
================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:1070
+ int64_t idx = it.index();
+ if (idx == index) {
+ continue;
----------------
nit: Please remove trivial braces. Also can you just inline the 'idx' variable into its use?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74880/new/
https://reviews.llvm.org/D74880
More information about the llvm-commits
mailing list