[PATCH] D61314: [SCCP] Remove forcedconstant, go to overdefined instead

Thu Feb 20 14:02:40 PST 2020

fhahn added a comment.

In D61314#1881334 <https://reviews.llvm.org/D61314#1881334>, @efriedma wrote:

> Yes, that sounds fine

I'll probably will get the results early next week. I first have to add handling for AND to limit the ranges.

I also pushed a small follow up fix 99809f98d7bb <https://reviews.llvm.org/rG99809f98d7bb18dbe3be543942a4b467dff7e92e> which excludes loads from being marked as overdefined in ResolvedUndefsIn, as this breaks an invariant that all non-store users of unknown constants are replaced and causes a crash. I think that should be fine, especially as it is not related to forcedconstants, but please let me know if you have any concerns, then I'll revert this again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61314/new/

https://reviews.llvm.org/D61314