[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Thu Feb 20 13:16:49 PST 2020

probinson added a comment.

In D73086#1885293 <https://reviews.llvm.org/D73086#1885293>, @SouraVX wrote:

> Hi Thanks for your comments, this revision is getting ontrack/offtrack a bit. Sorry about that. As for `opcode_openrand_table` I initially added a FIXME me for that, but removed after
>  David's remark in D72828 <https://reviews.llvm.org/D72828> -
>  `I don't think this is a FIXME situation - LLVM has no extensions here, so there's no need for the opcode_operands_table.`

That's because D72828 <https://reviews.llvm.org/D72828> is the producer side; and LLVM has no need to emit the opcode_operands_table.
This patch is the consumer (dumper) side, and should be prepared for inputs that do have an opcode_operands_table (and don't have a debug_line_offset, or might be in 64-bit format).  The dumper should operate correctly on objects produced by other compilers, not just Clang, and support all DWARF v5 features of the .debug_macro section.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086