[PATCH] D74916: [MLIR] Added llvm.indirect_br

[shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.

Hi @rriddle ! Thanks for the comments. I have updated the patch with more context now. Also, I have addressed all comments except one. Please let me know if you think I should change it to ArrayRef (I mentioned my reason in the inline comment).



================
Comment at: mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp:853
+    Builder *b, OperationState &result, Value address,
+    DenseMap<Block *, SmallVector<Value, 4>> successors) {
+  SmallVector<Value, 1> ops;
----------------
rriddle wrote:
> Do we need a map here? Can you just pass a ArrayRef<std::pair<>> instead?
My reason for going with map here was that with ArrayRef<std::pair<>>, duplication of labels will have to be handled here (avoid entering the same label twice). Please let me know if you still want me to use ArrayRef<std::pair<>>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74916/new/

https://reviews.llvm.org/D74916