[PATCH] D74506: [SystemZ] Support the kernel backchain

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 10:11:15 PST 2020


jonpa updated this revision to Diff 245684.
jonpa marked 5 inline comments as done.
jonpa added a comment.

> However, we now have duplicated computation between LowerFormalArguments and assignCalleeSavedSpillSlots again, which I don't really like.
> 
> I'm wondering whether the best solution wouldn't be to simply make the SystemZFrameLowering::getRegSpillOffset routine take packed stack into account itself.

Yes, that seems even better :-)  getRegSpillOffset() MF argument non-const due to usePackedStack().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74506/new/

https://reviews.llvm.org/D74506

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/mbackchain.c
  llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
  llvm/lib/Target/SystemZ/SystemZFrameLowering.h
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/test/CodeGen/SystemZ/frame-23.ll
  llvm/test/CodeGen/SystemZ/frame-24.ll
  llvm/test/CodeGen/SystemZ/frameaddr-02.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74506.245684.patch
Type: text/x-patch
Size: 16684 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200220/9fbd7ada/attachment.bin>


More information about the llvm-commits mailing list