[PATCH] D74864: [MLIR] Move from using target_link_libraries to LINK_LIBS for llvm libraries.

[Valentin Churavy via Phabricator via llvm-commits]

vchuravy added a comment.
Herald added a subscriber: bader.

> I asked in another revision, but I don't think I got an answer: what is the story for the circular dependency if we were to use MLIR in LLVM in the future? I'd be worried about adding barriers into this and I have some memory of a previous discussion that keeping a single .so would be somehow required?

I think way of doing that would be to remove `libMLIR` (all users of that library would need to use `libLLVM` instead), Right now the MLIR libraries are included in LLVM_AVAILABLE_LIBS, but they are not part of `LLVM_COMPONENT_LIBS` which is the set of things that are considered the inclusion into the shared library. So instead of `add_llvm_library` we would use `add_llvm_component_library`.

All the work that Stephen is doing is still required otherwise MLIR wouldn't work as part of the `libLLVM`. The same with your recent work on reducing the use of static initializers (I think).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74864/new/

https://reviews.llvm.org/D74864