[PATCH] D74905: Fix some typos in the MLIR documentation.

Matthias Kramm via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 08:12:29 PST 2020


matthiaskramm created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
matthiaskramm added a reviewer: rriddle.

Fix minor typos in the tutorial and the "writing a pass" page.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74905

Files:
  mlir/docs/Tutorials/Toy/Ch-4.md
  mlir/docs/Tutorials/Toy/Ch-5.md
  mlir/docs/Tutorials/Toy/Ch-6.md
  mlir/docs/WritingAPass.md


Index: mlir/docs/WritingAPass.md
===================================================================
--- mlir/docs/WritingAPass.md
+++ mlir/docs/WritingAPass.md
@@ -127,7 +127,7 @@
 
 ### Querying Analyses
 
-The base `OperationPass` class provide utilities for querying and preserving
+The base `OperationPass` class provides utilities for querying and preserving
 analyses for the current operation being processed.
 
 *   OperationPass automatically provides the following utilities for querying
Index: mlir/docs/Tutorials/Toy/Ch-6.md
===================================================================
--- mlir/docs/Tutorials/Toy/Ch-6.md
+++ mlir/docs/Tutorials/Toy/Ch-6.md
@@ -275,7 +275,7 @@
 Setting up a JIT to run the module containing the LLVM dialect can be done using
 the `mlir::ExecutionEngine` infrastructure. This is a utility wrapper around
 LLVM's JIT that accepts `.mlir` as input. The full code listing for setting up
-the JIT can be found in `Ch6/toy.cpp` in the `runJit()` function:
+the JIT can be found in `Ch6/toyc.cpp` in the `runJit()` function:
 
 ```c++
 int runJit(mlir::ModuleOp module) {
Index: mlir/docs/Tutorials/Toy/Ch-5.md
===================================================================
--- mlir/docs/Tutorials/Toy/Ch-5.md
+++ mlir/docs/Tutorials/Toy/Ch-5.md
@@ -39,7 +39,7 @@
 *   A set of
     [Rewrite Patterns](../../DialectConversion.md#rewrite-pattern-specification)
 
-    -   These are the set of [patterns](../../QuickstartRewrites.md) used to
+    -   This is the set of [patterns](../../QuickstartRewrites.md) used to
         convert `illegal` operations into a set of zero or more `legal` ones.
 
 *   Optionally, a [Type Converter](../../DialectConversion.md#type-conversion).
Index: mlir/docs/Tutorials/Toy/Ch-4.md
===================================================================
--- mlir/docs/Tutorials/Toy/Ch-4.md
+++ mlir/docs/Tutorials/Toy/Ch-4.md
@@ -315,7 +315,7 @@
 
 At this point, each of the necessary Toy operations provide a mechanism by which
 to infer their output shapes. The ShapeInferencePass is a FunctionPass: it will
-runs on each Function in isolation. MLIR also supports general
+run on each Function in isolation. MLIR also supports general
 [OperationPasses](../../WritingAPass.md#operation-pass) that run on any isolated
 operation (i.e. other function-like operations), but here our module only
 contains functions, so there is no need to generalize to all operations.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74905.245659.patch
Type: text/x-patch
Size: 2453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200220/c17152b5/attachment.bin>


More information about the llvm-commits mailing list