[PATCH] D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 07:53:50 PST 2020


asb added a comment.

In D68964#1884580 <https://reviews.llvm.org/D68964#1884580>, @davidlt wrote:

> Yes, please backport (if possible) all other related changes mentioned above (if they are not yet part of 10.0).
>
> This would help distributions to avoid hacking LDFLAGS / build systems files while building LLVM/Clang stack on Linux.


It's unfortunate, but as Hans says this series of patches is likely too much at this stage in the release process. If there's a 10.0.1, perhaps it makes sense there. They benefit the RISC-V community, but there's a risk of regressing somewhere else in a way that's probably not fair to other targets and their release testers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68964/new/

https://reviews.llvm.org/D68964





More information about the llvm-commits mailing list