[PATCH] D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V

Thu Feb 20 06:49:28 PST 2020

hans added a comment.

In D68964#1884522 <https://reviews.llvm.org/D68964#1884522>, @luismarques wrote:

> In D68964#1882946 <https://reviews.llvm.org/D68964#1882946>, @asb wrote:
>
> > The backport request seems ok to me, assuming you're happy taking a patch like this at this stage in the release process.
>
>
> This patch is part of a broader effort from @gokturk, where the various patches addressed different facets of this issue. If this is to be backported, then probably all of them should:
>
> - D68899 <https://reviews.llvm.org/D68899>
> - D69003 <https://reviews.llvm.org/D69003>
> - D69444 <https://reviews.llvm.org/D69444>
> - D69869 <https://reviews.llvm.org/D69869>
> - D68964 <https://reviews.llvm.org/D68964> (this one)
>
>   To properly land D69869 <https://reviews.llvm.org/D69869> you'll need the tweak I introduced in commit f128f442a3d <https://reviews.llvm.org/rGf128f442a3d23674bee19ae18e29f92c9dfe40cd>, otherwise MSVC builds will fail. (@hans)

Oh I see. I've backed it out again in d75ce45777d9802d43b555993fde8ed6562fb368 <https://reviews.llvm.org/rGd75ce45777d9802d43b555993fde8ed6562fb368>, this is too much stuff to land so late. I think it can wait until the 11 release.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68964/new/

https://reviews.llvm.org/D68964