[PATCH] D74896: build_llvm_package.bat: Produce zip files in addition to the installers

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 06:49:28 PST 2020


thakis added inline comments.


================
Comment at: llvm/utils/release/build_llvm_package.bat:98
+del repack\Uninstall.exe
+7z a LLVM-%package_version%-win32.zip .\repack\* -mx9
 cd ..
----------------
I'm not familiar with this script, but rather than "create installer, then unpack it, remove some stuff, repack" would it make more sense to have "create archive with just the stuff we want to be in the archive, then unpack that and add files we need for installer" as the overall flow?

Then you could also use the "7za" executable, which I believe has fewer deps (at least it was easier to use in chromium/win cross builds).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74896/new/

https://reviews.llvm.org/D74896





More information about the llvm-commits mailing list