[PATCH] D68512: [PATCH 29/38] [noalias] Introduce PropagateAndConvertNoAlias pass

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 06:40:01 PST 2020


jeroen.dobbelaere marked an inline comment as done.
jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/PropagateAndConvertNoAlias.cpp:779
+            // We try to store a restrict pointer - restrictness
+            // FIXME: introduce a llvm.noalias.arg.guard
+            //   although escape analysis is already handling it
----------------
A testcase from Alexey, triggers this FIXME (see http://lists.llvm.org/pipermail/llvm-dev/2020-February/139358.html)

We should do the same here as in lines 810-835, but on Operand 0.

As this is the third time we have this kind of code, it should also be refactored out.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68512/new/

https://reviews.llvm.org/D68512





More information about the llvm-commits mailing list