[PATCH] D74750: [X86] Rewrite LowerBRCOND to remove dead code and handle ISD::SETCC and overflow ops directly.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 04:33:52 PST 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM, although it'd have been easier to grok in smaller changes tbh.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:2688
+             Opc == ISD::USUBO || Opc == ISD::SMULO || Opc == ISD::UMULO));
+  }
+
----------------
pre-commit this and the AArch64ISelLowering.cpp change as an NFC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74750/new/

https://reviews.llvm.org/D74750





More information about the llvm-commits mailing list