[llvm] dbfc682 - SpeculativeExecution: fixed ingoring free execution

[via llvm-commits]

Author: dfukalov
Date: 2020-02-20T14:45:02+03:00
New Revision: dbfc682e2ba2581e214fabb04ba1b555ff8b274a

URL: https://github.com/llvm/llvm-project/commit/dbfc682e2ba2581e214fabb04ba1b555ff8b274a
DIFF: https://github.com/llvm/llvm-project/commit/dbfc682e2ba2581e214fabb04ba1b555ff8b274a.diff

LOG: SpeculativeExecution: fixed ingoring free execution

Summary:
After updating cost model in AMDGPU target (47a5c36b37f0) the pass started to
ignore some BBs since they got all instructions estimated as free.

Reviewers: arsenm, chandlerc, nhaehnle

Reviewed By: nhaehnle

Subscribers: jvesely, wdng, nhaehnle, tpr, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74825

Added: 
    llvm/test/CodeGen/AMDGPU/speculative-execution-freecasts.ll

Modified: 
    llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp b/llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp
index c8d899bb4871..6ad5c621abe4 100644
--- a/llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp
+++ b/llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp
@@ -279,9 +279,6 @@ bool SpeculativeExecutionPass::considerHoistingFromTo(
     }
   }
 
-  if (TotalSpeculationCost == 0)
-    return false; // nothing to hoist
-
   for (auto I = FromBlock.begin(); I != FromBlock.end();) {
     // We have to increment I before moving Current as moving Current
     // changes the list that I is iterating through.

diff  --git a/llvm/test/CodeGen/AMDGPU/speculative-execution-freecasts.ll b/llvm/test/CodeGen/AMDGPU/speculative-execution-freecasts.ll
new file mode 100644
index 000000000000..602207b69284
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/speculative-execution-freecasts.ll
@@ -0,0 +1,30 @@
+; RUN: opt < %s -S -mtriple=amdgcn-unknown-amdhsa -speculative-execution \
+; RUN:   -spec-exec-max-speculation-cost 1 -spec-exec-max-not-hoisted 1 \
+; RUN:   | FileCheck %s
+
+; CHECK-LABEL: @ifThen_bitcast(
+; CHECK: bitcast
+; CHECK: br i1 true
+define void @ifThen_bitcast(i32 %y) {
+  br i1 true, label %a, label %b
+
+a:
+  %x = bitcast i32 %y to float
+  br label %b
+
+b:
+  ret void
+}
+
+; CHECK-LABEL: @ifThen_addrspacecast(
+; CHECK: addrspacecast
+; CHECK: br i1 true
+define void @ifThen_addrspacecast(i32* %y) {
+  br i1 true, label %a, label %b
+a:
+  %x = addrspacecast i32* %y to i32 addrspace(1)*
+  br label %b
+
+b:
+  ret void
+}