[PATCH] D74736: [ELF] Ignore the maximum of input section alignments for two cases

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/LinkerScript.cpp:767
+    // The alignment is ignored.
+    ctx->outSec->addr = pos;
+  } else {
----------------
It is a bit strange to see that `expandMemoryRegions` is now gone from this path.
Is it correct?


================
Comment at: lld/test/ELF/linkerscript/outsections-addr.s:86
 #CHECK:    ]
-#CHECK:    Address: 0x5010
-#CHECK:    Offset: 0x4010
-#CHECK:    Size: 8
+#CHECK:    Address: 0x5001
+#CHECK:    Offset: 0x4001
----------------
MaskRay wrote:
> I can do a follow-up change to change the llvm-readobj test to use llvm-readelf.
> 
> `llvm-readobj -S` output is very hard to read.
I fully agree with "llvm-readobj -S output is very hard to read" here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74736/new/

https://reviews.llvm.org/D74736