[PATCH] D74879: [llvm-objcopy][test] Improve empty section tests
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 20 00:12:49 PST 2020
grimar added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/empty-section.test:5
+
+# CHECK1: Name Type Address Off Size ES Flg Lk Inf Al
+# CHECK1-NEXT: NULL 0000000000000000 000000 000000 00 0 0 0
----------------
Can you add a comment here and for the test below?
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/empty-section.test:71
+ Type: SHT_PROGBITS
+ Flags: [SHF_ALLOC]
+ AddressAlign: 0x1000
----------------
`[SHF_ALLOC]` is one byte off.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74879/new/
https://reviews.llvm.org/D74879
More information about the llvm-commits
mailing list