[PATCH] D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR

Wed Feb 19 21:50:50 PST 2020

mehdi_amini added inline comments.

================
Comment at: mlir/examples/toy/Ch6/CMakeLists.txt:55
+  MLIROpenMP
+  LLVMFrontendOpenMP
   MLIRStandardOps
----------------
kiranchandramohan wrote:
> kiranchandramohan wrote:
> > ftynse wrote:
> > > Why are these changes necessary? The code doesn't seem to be modifying the tutorial. 
> > Are you asking specifically for the whole-archive link or for target_link_libraries also?
> > 
> > I was getting some link errors since the OpenMP symbols are needed now.
> As mentioned before, this was required to the dependence of MLIRTranslation on LLVMFrontendOpenMP.
This seems like a missing transitive dependency: it does not seem right to add this here. The dependency on LLVMFrontendOpenMP needs to be specified on the library that is depending on it instead of pushed to every client (in this case I believe MLIRLLVMIR)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72962/new/

https://reviews.llvm.org/D72962