[PATCH] D74507: [llvm-objdump] Print method name from debug info in disassembly output.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:652
+      LineInfo.FunctionName != OldLineInfo.FunctionName)
+    OS << Delimiter << LineInfo.FunctionName << "():\n";
+  if (LineInfo.FileName != DILineInfo::BadString && LineInfo.Line != 0)
----------------
rupprecht wrote:
> rupprecht wrote:
> > dblaikie wrote:
> > > Is the intent to print the demangled name? The test doesn't verify demangling is happening (since it uses unmangled names to begin with) & it doesn't look like it is happening, given   SymbolizerOpts.Demangle = false; on line 569
> > For GNU compatibility, it should actually print the mangled string. I wouldn't mind if we changed it & also suggested this change for GNU binutils though, it seems like an oversight that GNU objdump -ldC does not demangle here.
> > 
> > Anyway, added a test case to capture current behavior.
> Proposed a patch to GNU objdump: https://sourceware.org/ml/binutils/2020-02/msg00369.html
> 
> I'll keep this patch consistent with the outcome of that (possibly post-commit).
Final reply for this comment: the GNU objdump patch was accepted & has landed in trunk, so I updated the patch to also demangle here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74507/new/

https://reviews.llvm.org/D74507