[PATCH] D71960: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing instructions.

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 14:58:31 PST 2020


baziotis added a comment.

In D71960#1883463 <https://reviews.llvm.org/D71960#1883463>, @jdoerfert wrote:

> In D71960#1877443 <https://reviews.llvm.org/D71960#1877443>, @baziotis wrote:
>
> > Fixed test which actually exposed a FIXME. Again for the same reason, it doesn't seem to get a known value from `AAValueSimplify`.
> >  Should I go ahead and change to unreachable the assumed instructions as well? Meaning in `manifest()`, after the updates have finished.
>
>
> Yes, I think something like that makes sense. Let's do that in a follow up though. This looks good now and I'll commit it once I get the chance.


Yes, ok, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71960/new/

https://reviews.llvm.org/D71960





More information about the llvm-commits mailing list