[PATCH] D74640: [LoopRotate] Add explicit flag to require MSSA.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:80
       MaxHeaderSize = unsigned(SpecifiedMaxHeaderSize);
+    RequiresMSSA = ReqMSSA;
   }
----------------
nit: initialise directly in the initialiser list?


================
Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:88
+    if (EnableMSSALoopDependency) {
+      if (RequiresMSSA)
+        AU.addRequired<MemorySSAWrapperPass>();
----------------
Would it be slightly simpler to just have RequireMSSA == true mean that we require and preserve it and RequireMSSA == false means neither require nor preserve it? I think both approaches are fine, but  in the current pipeline the case we can preserve MSSA without requiring it is not going to happen I guess?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74640/new/

https://reviews.llvm.org/D74640