[PATCH] D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test

[Anh Tuyen Tran via Phabricator via llvm-commits]

anhtuyen marked an inline comment as done.
anhtuyen added inline comments.


================
Comment at: compiler-rt/test/tsan/lit.cfg.py:78
 
-config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash") + " "))
+config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash") + " " + config.deflake_threshold))
 
----------------
delcypher wrote:
> anhtuyen wrote:
> > delcypher wrote:
> > > @anhtuyen This is breaking our tests. There's a missing space at the end of the substitution which means the command produced is something like
> > > 
> > > ```
> > > deflake.bash 10/path/to/binary
> > > ```
> > > 
> > > when it should be
> > > 
> > > ```
> > > deflake.bash 10 /path/to/binary
> > > ```
> > Hello @delcypher
> > This does not happen on our machines, but sorry for breaking your test. The fix is so simple that I can commit it in a few minutes. However, can you give me some info about your machine so that I can test it (if I have a similar one) before pushing the fix.
> I've landed a quick fix in ddd2257f48a83843aa35e7cbd337c3fe0c103598
Yes, mine collided it with yours above! Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73707/new/

https://reviews.llvm.org/D73707