[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added a comment.

In D74691#1883317 <https://reviews.llvm.org/D74691#1883317>, @jdoerfert wrote:

> In D74691#1883013 <https://reviews.llvm.org/D74691#1883013>, @omarahmed wrote:
>
> > [...]
> >  as the code puts on this function willreturn attribute and in the file read_write_returned_arguments_scc.ll it doesn't contain willreturn attribute so it gives an error with filecheck
>
>
> It should have. Your extension to `AAWillReturn` should generally result in more `willreturn` attributes being deduced. That is the point after all. We need to verify each change to the CHECK lines though. We should also write explicit tests for loops with and without upper trip count limits, assuming we don't have them already.


I just saw the test, and assuming I don't miss anything inter-procedural that happens, the previous version of `containsCycle()` should have been able to deduce that this does not have a loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691