[PATCH] D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 19 11:46:43 PST 2020
delcypher added inline comments.
================
Comment at: compiler-rt/test/tsan/lit.cfg.py:78
-config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash") + " "))
+config.substitutions.append( ("%deflake ", os.path.join(os.path.dirname(__file__), "deflake.bash") + " " + config.deflake_threshold))
----------------
@anhtuyen This is breaking our tests. There's a missing space at the end of the substitution which means the command produced is something like
```
deflake.bash 10/path/to/binary
```
when it should be
```
deflake.bash 10 /path/to/binary
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73707/new/
https://reviews.llvm.org/D73707
More information about the llvm-commits
mailing list