[PATCH] D74764: [yaml2obj][WIP] - Automatically assign sh_addr for allocatable sections.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 19 11:09:02 PST 2020
MaskRay added a comment.
The code change looks good to me now.
================
Comment at: llvm/test/tools/yaml2obj/ELF/section-address-assign.yaml:64
+ Type: SHT_PROGBITS
+ Flags: [ SHF_ALLOC ]
+## Used to trigger creation of .dynsym and .dynstr.
----------------
grimar wrote:
> MaskRay wrote:
> > Add a non-SHF_ALLOC section (e.g. .rela.debug_info) to test this rule applies on non-SHF_ALLOC sections.
> We have `.strtab` and `.shstrtab` added implicitly. They are non-SHF_ALLOC.
> I think I just do not understand what exactly you want me to test for them?
.shstr and .shstrtab are non-SHF_ALLOC. I think it is fine not adding another non-SHF_ALLOC section.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74764/new/
https://reviews.llvm.org/D74764
More information about the llvm-commits
mailing list