[PATCH] D74809: [MBP][X86] Include static prof data when collecting loop BBs
Bill Wendling via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 19 10:38:06 PST 2020
void added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:2517
+ const BasicBlock *BB = MBB->getBasicBlock();
+ return BB && BB->getTerminator()->hasMetadata(LLVMContext::MD_prof);
+ })) {
----------------
nickdesaulniers wrote:
> I really wish this was a method on `MachineBlockPlacement` or `MachineLoop` rather than a lambda in an `if` statement.
Is it that it's cleaner to do it that way? The logic is going to be basically the same.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74809/new/
https://reviews.llvm.org/D74809
More information about the llvm-commits
mailing list