[PATCH] D74818: [mlir][Parser] Use APFloat instead of FloatAttr when parsing DenseElementsAttrs.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 10:28:50 PST 2020


rriddle added a comment.

In D74818#1882681 <https://reviews.llvm.org/D74818#1882681>, @jpienaar wrote:

> A benchmark showing impact would be nice ;-)


We don't really have any open benchmarks to run at this point which is unfortunate. Though internally this knocked about 17 seconds off of parsing a .mlir blob with a large number of floating point constants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74818/new/

https://reviews.llvm.org/D74818





More information about the llvm-commits mailing list