[PATCH] D74691: [Attributor] add some pattern to containsCycle

[omar ahmed via Phabricator via llvm-commits]

omarahmed added a comment.

In this test shouldn't it have the attribute willreturn

  define i32* @external_sink_ret2_nrw(i32* %n0, i32* %r0, i32* %w0) {
  entry:
    %tobool = icmp ne i32* %n0, null
    br i1 %tobool, label %if.end, label %if.then
  
  if.then:                                          ; preds = %entry
    br label %return
  
  if.end:                                           ; preds = %entry
    %0 = load i32, i32* %r0, align 4
    store i32 %0, i32* %w0, align 4
    br label %return
  
  return:                                           ; preds = %if.end, %if.then
    ret i32* %w0
  }

as the code puts on this function willreturn attribute and in the file read_write_returned_arguments_scc.ll it doesn't contain willreturn attribute so it gives an error with filecheck


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691